Skip to content

MAINT: update github workflows files#405

Merged
Gui-FernandesBR merged 5 commits intofix/env-analysis-dependency-importsfrom
maint/update-git-actions
Sep 13, 2023
Merged

MAINT: update github workflows files#405
Gui-FernandesBR merged 5 commits intofix/env-analysis-dependency-importsfrom
maint/update-git-actions

Conversation

@Gui-FernandesBR
Copy link
Copy Markdown
Member

@Gui-FernandesBR Gui-FernandesBR commented Sep 7, 2023

Pull request type

Please check the type of change your PR introduces:

  • ReadMe, Docs and GitHub maintenance

Pull request checklist

Please check if your PR fulfills the following requirements, depending on the type of PR:

  • ReadMe, Docs and GitHub maintenance:

    • Spelling has been verified
    • Code docs are working correctly

What is the current behavior?

The github workflows are not perfect.

What is the new behavior?

They continue not being perfect, but at least now they are updated. Also:

  • no longer assigns the issue to its author (only for PRs)
  • deleted the useless auto-assign-projects file
  • runs the pytest without the [all] option
  • assigns @phmbressan as a reviewer in the PRs. I was really missing this.

Does this introduce a breaking change?

  • No

Other information

  • This PR already works as a test for the current file
  • Maybe we could merge master into beta/v1 to catch this little guy: 18ceea1

@Gui-FernandesBR
MAINT: update github workflows files
174663b 
- no longer assigns the issue to its author (only for PRs)
- deleted the useless auto-assign-projects file
- runs the pytest without the [all] option
@github-actions github-actions bot requested a review from MateusStano September 7, 2023 02:00
@Gui-FernandesBR Gui-FernandesBR added this to the Release v1.1.0 milestone Sep 7, 2023
@phmbressan
Copy link
Copy Markdown
Collaborator

phmbressan commented Sep 8, 2023

Is this PR really working as intended? You mentioned in the description that it is by itself a test of the new files, but I have not been assigned as a reviewer.

Furthermore, shouldn't the destination branch of this PR be beta/v1.0.0?

phmbressan
phmbressan requested changes Sep 8, 2023
View reviewed changes
@Gui-FernandesBR Gui-FernandesBR added the C.I. Continuous Integration (Workflows and actions) label Sep 10, 2023
@Gui-FernandesBR
Copy link
Copy Markdown
Member Author

Gui-FernandesBR commented Sep 10, 2023

Is this PR really working as intended? You mentioned in the description that it is by itself a test of the new files, but I have not been assigned as a reviewer.

Furthermore, shouldn't the destination branch of this PR be beta/v1.0.0?

You know, since there's no way to test it, sometimes you have to trust that the workflows are gonna work 😅😅😅

  • But yes, I can confirm that the same behavior [of you not being assigned as a reviewer yet] happened in the first time we introduced such tests: MAINT: auto assign workflows #214
  • Not actually, the maint/update-git-actions was created from the fix/env-analysis-dependency-imports branch, so if I change the direction to beta/v1 it is gonna show way more additions than what is suppose to show. Maybe a good idea is to merge FIX: env analysis dependency imports #403 before this one!

Anyway, many thanks for reviewing it :)
I'm sending a re-review request now

phmbressan
phmbressan approved these changes Sep 10, 2023
View reviewed changes
Copy link
Copy Markdown
Collaborator

@phmbressan phmbressan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I agree with the changes made. Approved.

@Gui-FernandesBR
Copy link
Copy Markdown
Member Author

Gui-FernandesBR commented Sep 13, 2023

Merging it into fix/env-analysis-dependency-imports

@Gui-FernandesBR Gui-FernandesBR merged commit cfdd041 into fix/env-analysis-dependency-imports Sep 13, 2023
@Gui-FernandesBR Gui-FernandesBR deleted the maint/update-git-actions branch September 14, 2023 18:55
@Gui-FernandesBR
Copy link
Copy Markdown
Member Author

Gui-FernandesBR commented Sep 16, 2023

Is this PR really working as intended? You mentioned in the description that it is by itself a test of the new files, but I have not been assigned as a reviewer.
Furthermore, shouldn't the destination branch of this PR be beta/v1.0.0?

You know, since there's no way to test it, sometimes you have to trust that the workflows are gonna work 😅😅😅

  • But yes, I can confirm that the same behavior [of you not being assigned as a reviewer yet] happened in the first time we introduced such tests: MAINT: auto assign workflows #214
  • Not actually, the maint/update-git-actions was created from the fix/env-analysis-dependency-imports branch, so if I change the direction to beta/v1 it is gonna show way more additions than what is suppose to show. Maybe a good idea is to merge FIX: env analysis dependency imports #403 before this one!

Anyway, many thanks for reviewing it :) I'm sending a re-review request now

Actually, I think the workflow you start working correctly only when it gets to the master branch.
Let's wait a bit more to see.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@phmbressan phmbressan phmbressan approved these changes

@giovaniceotto giovaniceotto Awaiting requested review from giovaniceotto

@MateusStano MateusStano Awaiting requested review from MateusStano

Assignees

@Gui-FernandesBR Gui-FernandesBR

Labels

C.I. Continuous Integration (Workflows and actions)

Projects

None yet

Milestone

Release v1.X.0

Development

Successfully merging this pull request may close these issues.

2 participants

@Gui-FernandesBR @phmbressan